gRPC-Web client and server #695

JamesNK · 2019-12-14T04:37:00Z

Fixes #99

Implementation of https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md for ASP.NET Core server and .NET Core gRPC client.

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs

src/Grpc.AspNetCore.Server/Internal/CallHandlers/ServerCallHandlerBase.cs

src/Shared/CommonGrpcProtocolHelpers.cs

src/Grpc.AspNetCore.Web/GrpcWebOptions.cs

src/Grpc.AspNetCore.Web/GrpcWebServiceExtensions.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebFeature.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebProtocolHelpers.cs

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebFeature.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebProtocolHelpers.cs

src/Grpc.Net.Client.Web/Internal/GrpcWebResponseContent.cs

src/Grpc.Net.Client.Web/GrpcWebHandler.cs

src/Grpc.Net.Client.Web/Internal/GrpcWebProtocolConstants.cs

src/Grpc.Net.Client.Web/GrpcWebHandler.cs

src/Grpc.Net.Client.Web/Internal/GrpcWebResponseContent.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs

JunTaoLuo

Still taking a look at the base64 pipereader/writer and request/responsestream

src/Grpc.AspNetCore.Web/Internal/GrpcWebProtocolConstants.cs

src/Grpc.AspNetCore.Web/Internal/HttpCharacters.cs

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs

src/Grpc.Net.Client.Web/Internal/GrpcWebResponseContent.cs

src/Grpc.Net.Client.Web/Internal/GrpcWebResponseStream.cs

brmdbr · 2019-12-30T13:34:27Z

I've build it from the sources to use in my Blazor client side app and I get the following error: WASM: Status(StatusCode=Internal, Detail="Error starting gRPC call: Cannot invoke method because it was wiped. See stack trace for details.")

Is this a problem related to this pr or am I implementing something wrong?

JamesNK · 2019-12-30T19:10:26Z

Instead of passing HttpClientHandler to GrpcWebHandler, create WasmHttpMessageHandler. There seems to be a bug in Blazor that its not public. You can do this:

var wasmHttpMessageHandlerType = Assembly.Load("WebAssembly.Net.Http").GetType("WebAssembly.Net.Http.HttpClient.WasmHttpMessageHandler");
var wasmHttpMessageHandler = (HttpMessageHandler)Activator.CreateInstance(wasmHttpMessageHandlerType);

dotnet/aspnetcore#17115

@SteveSandersonMS

brmdbr · 2019-12-30T23:15:40Z

Thanks @JamesNK, that seems to work, I no longer get the cannot invoke error. I get another error now: WASM: Status(StatusCode=Internal, Detail="Error starting gRPC call: Buffer is not large enough for header")

Using this code:

var wasmHttpMessageHandlerType = Assembly.Load("WebAssembly.Net.Http").GetType("WebAssembly.Net.Http.HttpClient.WasmHttpMessageHandler");
var wasmHttpMessageHandler = (HttpMessageHandler)Activator.CreateInstance(wasmHttpMessageHandlerType);
var httpClient = new HttpClient(new GrpcWebHandler(GrpcWebMode.GrpcWebText, wasmHttpMessageHandler));
var channel = GrpcChannel.ForAddress("https://localhost:5001", new GrpcChannelOptions
            {
                HttpClient = httpClient
            });
var client = new Protos.LessonService.LessonServiceClient(channel);
var lesson = await client.GetLessonAsync(new Protos.GetLessonRequest { AllowedChars = "asdfghjkl;qwertyuiop", NumberOfWords = 15, Seed = 1337 });

Any idea on this? Again I'm not sure if its related to the pr as I'm implementing in a similar way as the tests in the .web projects.

JamesNK · 2019-12-30T23:19:15Z

Ohh, I forgot that I modified the client slightly.

You'll need to also compile and use Grpc.Net.Client.

brmdbr · 2020-01-01T19:47:45Z

Ohh, I forgot that I modified the client slightly.

You'll need to also compile and use Grpc.Net.Client.

That fixed it! Thanks a lot.

SteveSandersonMS · 2020-01-02T18:11:43Z

Instead of passing HttpClientHandler to GrpcWebHandler, create WasmHttpMessageHandler. There seems to be a bug in Blazor that its not public

Thanks - will be fixed with dotnet/blazor#1960 (as in, HttpClientHandler will just work out of the box and you won't have to do any weird stuff involving WasmHttpMessageHandler).

JunTaoLuo

Some comments for the request/responsestreams. I'll finish up with the pipewriter/reader tomorrow.

src/Grpc.AspNetCore.Web/Internal/GrpcWebFeature.cs

src/Grpc.Net.Client.Web/Internal/Base64RequestStream.cs

src/Grpc.Net.Client.Web/Internal/Base64ResponseStream.cs

JunTaoLuo

Looks good but I'd like for pipe experts to take a look at the Base64PipeWriter and Base64PipeReader as well. @halter73 @jkotalik

src/Grpc.AspNetCore.Web/Internal/Base64PipeWriter.cs

JunTaoLuo

@halter73 @jkotalik can you guys take a look at the pipereader/writer logic as well?

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs

src/Grpc.Net.Client.Web/Internal/Base64ResponseStream.cs

jtattermusch

Initial set of comments, overall things are looking good but let's discuss the next steps in our sync-up.
Sorry for the delay.

src/Grpc.AspNetCore.Web/README.md

kokoro/build_nuget.sh

src/Grpc.AspNetCore.Web/README.md

src/Grpc.AspNetCore.Web/Internal/GrpcWebMode.cs

testassets/InteropTestsClient/RunGrpcWebTests.ps1

testassets/FunctionalTestsWebsite/Services/EchoService.cs

testassets/InteropTestsClient/InteropClient.cs

jtattermusch · 2020-01-08T11:08:24Z

testassets/InteropTestsWebsite/EchoService.cs

+    /// Written to as closely as possible mirror the behaviour of the C++ implementation in grpc/grpc-web:
+    /// https://github.com/grpc/grpc-web/blob/92aa9f8fc8e7af4aadede52ea075dd5790a63b62/net/grpc/gateway/examples/echo/echo_service_impl.cc
+    /// </summary>
+    public class EchoService : Grpc.Gateway.Testing.EchoService.EchoServiceBase


looks like you have a copy of the same service at testassets/FunctionalTestsWebsite/Services/EchoService.cs?

Yes. That's so it is tested by CI

test/FunctionalTests/Infrastructure/GrpcTestFixture.cs

jtattermusch

This is good enough as a preview implementation of the grpc-web functionality. LGTM, thanks for incorporating all the comments.

This will be in the next release as preview for people to test it out and provide feedback/report issues, but there won't be "stable" nuget packages yet.

The next steps and release criteria for official release will be driven by grpc/proposal#169.

JamesNK · 2020-01-09T19:05:06Z

🎈 🎉 🍰

johanbrandhorst · 2020-01-23T11:24:20Z

Hi, great work @JamesNK. Would you be interested in adding this implementation to the grpc-web compatibility tests I'm running? See https://github.com/johanbrandhorst/grpc-web-compatibility-test

muraray · 2020-02-10T10:24:30Z

That's one hell of a serious pull request... grpc port to .net core paradigm, very much appreciate your work, thanks a ton... looking forward using it in our next project...

JamesNK mentioned this pull request Dec 14, 2019

WIP gRPC-Web server #688

Closed

JamesNK requested review from jtattermusch and JunTaoLuo December 17, 2019 22:41

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Outdated Show resolved Hide resolved

Tratcher reviewed Dec 18, 2019

View reviewed changes

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Dec 18, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

Tratcher reviewed Dec 18, 2019

View reviewed changes

JamesNK commented Dec 20, 2019

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/GrpcWebMiddleware.cs Show resolved Hide resolved

JamesNK mentioned this pull request Dec 24, 2019

Add gRPC-Web Browser example #703

Merged

JunTaoLuo reviewed Dec 27, 2019

View reviewed changes

JamesNK mentioned this pull request Dec 27, 2019

Status(StatusCode=Internal, Detail="Bad gRPC response. Response protocol downgraded to HTTP/1.1." #705

Closed

JamesNK force-pushed the jamesnk/grpcweb4 branch from ed061a8 to 9b76a0b Compare December 30, 2019 22:43

Add gRPC-Web client and server

81fc1b1

JamesNK force-pushed the jamesnk/grpcweb4 branch from 9b76a0b to 81fc1b1 Compare December 30, 2019 22:45

JunTaoLuo reviewed Jan 3, 2020

View reviewed changes

PR feedback

2c733a4

campersau mentioned this pull request Jan 3, 2020

Replacement for WebAssemblyHttpMessageHandler? dotnet/aspnetcore#17115

Closed

JunTaoLuo reviewed Jan 3, 2020

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeWriter.cs Show resolved Hide resolved

src/Grpc.AspNetCore.Web/Internal/Base64PipeWriter.cs Outdated Show resolved Hide resolved

PR feedback

89296b5

JunTaoLuo approved these changes Jan 6, 2020

View reviewed changes

halter73 reviewed Jan 7, 2020

View reviewed changes

src/Grpc.AspNetCore.Web/Internal/Base64PipeReader.cs Show resolved Hide resolved

halter73 reviewed Jan 7, 2020

View reviewed changes

src/Grpc.Net.Client.Web/Internal/Base64ResponseStream.cs Show resolved Hide resolved

JamesNK added 2 commits January 7, 2020 14:03

PR feedback

af033f5

Clean up

464dfce

jtattermusch reviewed Jan 7, 2020

View reviewed changes

PR feedback

3299916

jtattermusch reviewed Jan 8, 2020

View reviewed changes

testassets/InteropTestsClient/InteropClient.cs Show resolved Hide resolved

only build grpcWeb packages in prerelease

c9338c7

jtattermusch reviewed Jan 8, 2020

View reviewed changes

PR feedback

4ca6260

jtattermusch approved these changes Jan 9, 2020

View reviewed changes

JamesNK merged commit bee59db into grpc:master Jan 9, 2020

JamesNK deleted the jamesnk/grpcweb4 branch January 9, 2020 19:04

guardrex mentioned this pull request Jan 18, 2020

gRPC-Web dotnet/AspNetCore.Docs#16598

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gRPC-Web client and server #695

gRPC-Web client and server #695

JamesNK commented Dec 14, 2019 •

edited

JunTaoLuo left a comment

brmdbr commented Dec 30, 2019

JamesNK commented Dec 30, 2019 •

edited

brmdbr commented Dec 30, 2019 •

edited

JamesNK commented Dec 30, 2019

brmdbr commented Jan 1, 2020

SteveSandersonMS commented Jan 2, 2020 •

edited

JunTaoLuo left a comment

JunTaoLuo left a comment •

edited

JunTaoLuo left a comment

jtattermusch left a comment

jtattermusch Jan 8, 2020

JamesNK Jan 8, 2020

jtattermusch left a comment

JamesNK commented Jan 9, 2020

johanbrandhorst commented Jan 23, 2020

muraray commented Feb 10, 2020

gRPC-Web client and server #695

gRPC-Web client and server #695

Conversation

JamesNK commented Dec 14, 2019 • edited

JunTaoLuo left a comment

Choose a reason for hiding this comment

brmdbr commented Dec 30, 2019

JamesNK commented Dec 30, 2019 • edited

brmdbr commented Dec 30, 2019 • edited

JamesNK commented Dec 30, 2019

brmdbr commented Jan 1, 2020

SteveSandersonMS commented Jan 2, 2020 • edited

JunTaoLuo left a comment

Choose a reason for hiding this comment

JunTaoLuo left a comment • edited

Choose a reason for hiding this comment

JunTaoLuo left a comment

Choose a reason for hiding this comment

jtattermusch left a comment

Choose a reason for hiding this comment

jtattermusch Jan 8, 2020

Choose a reason for hiding this comment

JamesNK Jan 8, 2020

Choose a reason for hiding this comment

jtattermusch left a comment

Choose a reason for hiding this comment

JamesNK commented Jan 9, 2020

johanbrandhorst commented Jan 23, 2020

muraray commented Feb 10, 2020

JamesNK commented Dec 14, 2019 •

edited

JamesNK commented Dec 30, 2019 •

edited

brmdbr commented Dec 30, 2019 •

edited

SteveSandersonMS commented Jan 2, 2020 •

edited

JunTaoLuo left a comment •

edited